Skip to content

NO-JIRA: Remove override of MIRROR_IMAGES for OVE - #1900

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-metal3:masterfrom
bfournie:fix-mirror-image-override
Jun 1, 2026
Merged

NO-JIRA: Remove override of MIRROR_IMAGES for OVE#1900
openshift-merge-bot[bot] merged 1 commit into
openshift-metal3:masterfrom
bfournie:fix-mirror-image-override

Conversation

@bfournie

@bfournie bfournie commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

MIRROR_IMAGES was set to false for ISO_NO_REGISTRY in #1897. this breaks the ability to use local images for testing OVE.

@openshift-ci
openshift-ci Bot requested review from andfasano and rwsu June 1, 2026 14:24
@andfasano

andfasano commented Jun 1, 2026

Copy link
Copy Markdown
Member

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2026
@bfournie
bfournie force-pushed the fix-mirror-image-override branch from 405ce5b to d25ecad Compare June 1, 2026 14:31
@openshift-ci

openshift-ci Bot commented Jun 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bfournie

bfournie commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

/cc @pawanpinjarkar

@openshift-ci
openshift-ci Bot requested a review from pawanpinjarkar June 1, 2026 14:32
@pawanpinjarkar

pawanpinjarkar commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2026
@bfournie
NO-JIRA: Remove override of MIRROR_IMAGES for OVE
7bc094c 
MIRROR_IMAGES was set to false for ISO_NO_REGISTRY
in openshift-metal3#1897.
this breaks the ability to use local images for testing OVE.
@bfournie
bfournie force-pushed the fix-mirror-image-override branch from d25ecad to 7bc094c Compare June 1, 2026 15:40
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2026
@pawanpinjarkar

pawanpinjarkar commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 500ae03 into openshift-metal3:master Jun 1, 2026
16 of 18 checks passed
@bfournie
bfournie deleted the fix-mirror-image-override branch June 1, 2026 20:18
@openshift-ci

openshift-ci Bot commented Jun 1, 2026

Copy link
Copy Markdown

@bfournie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 d25ecad link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-metal-ipi-bm-bond 7bc094c link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-ovn-ipv6 7bc094c link unknown /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-agent-compact-ipv4 7bc094c link unknown /test e2e-agent-compact-ipv4
ci/prow/e2e-metal-ipi-bm 7bc094c link unknown /test e2e-metal-ipi-bm
ci/prow/e2e-metal-ipi-serial-ipv4-1of2 7bc094c link unknown /test e2e-metal-ipi-serial-ipv4-1of2
ci/prow/e2e-metal-ipi-serial-ipv4-2of2 7bc094c link unknown /test e2e-metal-ipi-serial-ipv4-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andfasano andfasano Awaiting requested review from andfasano
@rwsu rwsu Awaiting requested review from rwsu
@pawanpinjarkar pawanpinjarkar Awaiting requested review from pawanpinjarkar

Assignees

@pawanpinjarkar pawanpinjarkar

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bfournie @andfasano @pawanpinjarkar